On Fri, Oct 16, 2020 at 1:28 PM Eduard Niesner <niesneredu...@gmail.com> wrote:
> I attached it as .txt. > > *Please note:* I made the code build and the SPI seems to work > as expected - I am communicating with an at45db flash over SPI and mounted > smartFS on it and the communication seems to work. I am not sure if > the changes that I did are enough or if the entire spi_interrupt function > should be surrounded by the #ifdef CONFIG_STM32H7_SPI_DMA condition as > well (and also where it is called from). > It would be good if someone with more experience that understands the > impact of the change could look into it. > > PS: If the changes look ok, I will register on github and create the pull > request. Do I need to get any approvals to create branches or pull > requests on nuttx incubator? > I haven't studied your patch but, regarding pull requests, it's better to fork the incubator-nuttx repo, create a branch in your own fork, and when ready, open a pull request from that. (Creating a branch allows you to continue making additional PRs from your fork, as GitHub doesn't allow to create multiple forks of the same thing.) You may find this helpful: https://nuttx.apache.org/docs/latest/contributing/index.html Cheers Nathan
