For a more detailed discussion on why the current RC is canceled, please head to https://github.com/apache/incubator-nuttx/issues/1363 I created the PRs to backport all the necessary commits. Brennan, if you've got some time to take a look and cut RC2 tonight, that would be great. Thanks in advance!
On Tue, Jul 7, 2020 at 7:24 PM Brennan Ashton <bash...@brennanashton.com> wrote: > > Yes this was basically cancelled already sorry I did not announce it. This > has been resolved as of yesterday but I need backport two more patches to > cut the release tonight. > > On Tue, Jul 7, 2020, 11:16 AM Adam Feuer <a...@starcat.io> wrote: > > > Hi, I need to change my vote to -1 for 9.1.0-RC1. > > > > I updated the checkrelease.sh script to build sim:nsh as suggested by > > Xiang. (No PR yet, but here's the script on my branch: checkrelease.sh.) > > > > I discovered that the RC1 release candidate appears to be missing this > > file: > > > > boards/sim/sim/sim/src/etc/init.d/rcS > > > > The script can build a git checkout from HEAD just fine. On the release > > candidate, it doesn't build, and gives this error: > > > > make[2]: Entering directory > > '/home/adam/src/nuttx/nuttx-sama5d3-xplained/nuttx/tools/tmp1/ > > dist.apache.org/nuttx/boards/sim/sim/sim/src' > > make[2]: *** No rule to make target 'etc/init.d/rcS', needed by > > 'etctmp/etc/init.d/rcS'. Stop. > > make[2]: Leaving directory > > '/home/adam/src/nuttx/nuttx-sama5d3-xplained/nuttx/tools/tmp1/ > > dist.apache.org/nuttx/boards/sim/sim/sim/src' > > Makefile:326: recipe for target '.depend' failed > > make[1]: *** [.depend] Error 2 > > make[1]: Leaving directory > > '/home/adam/src/nuttx/nuttx-sama5d3-xplained/nuttx/tools/tmp1/ > > dist.apache.org/nuttx/arch/sim/src' > > tools/Makefile.unix:441: recipe for target 'pass2dep' failed > > make: *** [pass2dep] Error 2 > > > > If you add the file, the build is ok. > > > > This seems to indicate a problem with the release candidate— for some > > reason the rcS file is not being included properly. Or am I getting > > something wrong...? > > > > -adam > > > > On Thu, Jul 2, 2020 at 11:25 AM Nathan Hartman <hartman.nat...@gmail.com> > > wrote: > > > > > On Thu, Jul 2, 2020 at 1:12 PM Nathan Hartman <hartman.nat...@gmail.com> > > > wrote: > > > > Summary: > > > > +1 to release > > > > > > > > Development system: Linux > > > > > > > > Verified: > > > > * Signatures (note GPG reports the key is expired) > > > > > > Correction, follow-up: I re-imported the key. GPG no longer reports > > > the key as expired. My vote remains +1. > > > > > > Cheers, > > > Nathan > > > > > > > > > -- > > Adam Feuer <a...@starcat.io> > >
