On Fri, Jul 3, 2020 at 7:44 PM Brennan Ashton <bash...@brennanashton.com> wrote: > > Haitao, > Thanks for catching that. I suspect this might have been around for a > while in the zip releases. > The release script checks out a tag to make sure we are getting what > we expect so I dont think we cut the wrong code > > What looks to be going on is we have files in .gitignore that are > being stripped when zipme.sh calls tar > ./nuttx/tools/zipme.sh:TAR+=" --exclude-vcs-ignores --exclude-vcs" > We are also stripping out all the z80 asm files which is really bad. > > I did a diff between the tag and the release tarball and I found this > diff -rq nuttx/ ../incubator-nuttx | grep -v gitignore > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_handlers.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_init.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_handlers.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_init.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_loader.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_program.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_getsp.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_io.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqcommon.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqsave.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_progentry.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_reset.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_restorecontext.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_saveusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_startup.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_head.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_restoreusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_rom.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_romvectors.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_saveusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectcommon.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectors.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_head.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_restoreusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_rom.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_saveusercontext.asm > Only in ../incubator-nuttx: .asf.yaml > Only in ../incubator-nuttx/boards/arm/samd5e5/metro-m4/scripts: nvm.srec > Only in ../incubator-nuttx/boards/arm/samd5e5/same54-xplained-pro/scripts: > nvm.srec > Only in ../incubator-nuttx/boards/sim/sim/sim/src/etc: init.d > Only in ../incubator-nuttx: .git > Only in ../incubator-nuttx: .github > Only in nuttx/: .version > > Anyone have a suggestion on how to handle this? I am tempted to > remove that option. > That would require making sure the repo is clean. I do this anyway by > doing a fresh shallow clone of the repo and checking that the tag is > exactly matching the commit > > --Brennan
Opened an issue in github. https://github.com/apache/incubator-nuttx/issues/1363 --Brennan
