On 6/24/2020 9:20 AM, Alan Carvalho de Assis wrote:
Hi Greg,
On 6/24/20, Gregory Nutt <spudan...@gmail.com> wrote:
Changing the default is not the problem. The problem is when the
default configuration value is changed, the all configurations effected
by that change in the default setting should be updated so that they are
not effected. That is, so the net result is no change. That was not
done and that is an error.
In this case, the NSH 'date' command used to default to 'disabled'
UNLESS an RTC was supported, then the default is 'enabled'. There error
is, that that the 'date' command should have also been explicitly
disabled in ALL NSH configurations that do not have the RTC enabled.
That has a negative user impact and would think that correcting that is
more important than meeting an artificial release deadline.
The TLS changes are harder for me to judge and the netdb change I
think just changes ram usage.
I don't believe that the TLS changes added any significant size. It
replaces one small, simple implementation with another small, simple
implementation. It is hard to envision how this would cause any
noticeable size increase. But perhaps.
Another thing that I noted in Alin's configuration comparison is that
the variadic version of the ioctl() interface is no longer optional.
That I expect will add a couple hundred bytes to the size of every
configuration.
The main cause of the size increase is the default 'date' command
setting. Not only does that enabled the NSH data command but draws all
of the time computation logic into the build. This will probably break
many of the more resource constrained configurations.
Currently it appears to depend on !CONFIG_DEFAULT_SMALL only:
config NSH_DISABLE_DATE
bool "Disable date"
default y if DEFAULT_SMALL
default n if !DEFAULT_SMALL
Shouldn't it depends on !CONFIG_DEFAULT_SMALL && CONFIG_RTC ?
BR,
Alan
I have looked at this too. I think that the correct change is to revert
commit 4adb83c754500cfebe4c24a498eb4139e3ff8866:
commit 4adb83c754500cfebe4c24a498eb4139e3ff8866
Author: chao.an <anc...@xiaomi.com>
Date: Tue Apr 7 16:33:05 2020 +0800
nshlib: remove the dependency of date on RTC
Change-Id: I98bd022fdc901ecb4e2e45a0faf779d83c260844
Signed-off-by: chao.an <anc...@xiaomi.com>
diff --git a/nshlib/Kconfig b/nshlib/Kconfig
index abc96d69..a6aa7906 100644
--- a/nshlib/Kconfig
+++ b/nshlib/Kconfig
@@ -259,8 +259,8 @@ config NSH_DISABLE_CMP
config NSH_DISABLE_DATE
bool "Disable date"
- default n if RTC
- default y if !RTC
+ default y if DEFAULT_SMALL
+ default n if !DEFAULT_SMALL
config NSH_DISABLE_DD
bool "Disable dd"
