On Fri, May 22, 2020 at 7:51 PM Alan Carvalho de Assis <acas...@gmail.com> wrote: > > Hi Takashi-san, > > On 5/22/20, Takashi Yamamoto <yamam...@midokura.com.invalid> wrote: > > hi, > > > > i'm working on mbedtls Makefile/Kconfig glue for NuttX. > > right now, it downloads and uses the mbedtls source code from > > the upstream as it is. (similarly to what netutils/cjson does) > > > > questions: > > > > 1. if we decide to contribute it, is there a chance to be accepted by > > NuttX? > > Yes, mbedtls should be a great contribution. > Many users want to use NuttX with HTTPS/TLS support and will spend > time doing this port themselves. > > > 2. if yes, which repository is appropriate? apps? > > Yes, apps of course. > > > 3. if apps, in which directory? netutils? crypto? > > Although crypto could be an option (but it doesn't exist inside apps/ > yet), I think netutils/ is a better option. >
But mbedtls can be used in more context than HTTPS/TLS like security boot, OTA and TEE, it doesn't make sense to put into netutils. A central folder(e.g. external) for 3rd party is a better choice because: 1.New user can find what already provide by NuttX quickly before start porting 2.Help PMC check LICENSE file reflect the truth 3.Follow other project practice > > 4. how do you think about adding tls support to netutils/webclient? > > > > I think it is better to create the mbedtls as a separated "library" > (note the quotes) instead of mixing it directly inside webclient, > because it could make it easier to users to use mbedtls on their web > applications. But, of course, it should be nice to have an option to > compile the webclient with the mbedtls "library" support. There are > some examples of "libraries" and applications on NuttX apps, i.e.: > gpsutils/minmea/minmea.c and an application using it: examples/gps. > Yes, mbedtls is better to integrate as a library, and then any builtin or 3rd party apps can utilize it. > BR, > > Alan