On Thu, Apr 23, 2020 at 9:13 AM Gregory Nutt <spudan...@gmail.com> wrote: > > As most of you know, there is a branch called SocketCAN in the > incubator_nuttx repository. This branch holds a port of port of VW's > socket CAN plus NXP copyrighted files. All are BSD licensed (the VW > code is dual licensed) and compatible with the Apache 2.0 license. > > The code is stuck on this branch branch because we have set a rule that > all new code must conform to the Apache 2.0 license. But there can be > exceptions to that rule. We can bring third party code into the > repository too as long as it has such a compatible license. Given that > we have been trying unsuccessfully to get an SGA from NXP, perhaps we > should consider this route. We will have to do a few things: > > 1. We need some advice from one of our mentors (Justin?) on exactly > what we need to do be bring this third party code into the > repository. I presume that everything is summarized here: > https://www.apache.org/legal/resolved.html (but I am not very good > at reading bureaucratic documents so nothing spoke clearly to me). > 2. We need to rebase the SocketCAN branch master, and > 3. Re-verify functionality of the SocketCAN branch (Peter would have to > do this), and finally, > 4. Merge the SocketCAN branch onto master. I don't think any further > review or checks are required (but ARE certainly welcom). All of > the PRs used to create the SocketCAN branch were previously reviewed > and the merge is very low risk since it should, in principle, effect > only the SocketCAN network sockets and a few CAN drivers. > > What say you all? Can we proceed on this and get this out of the way? > If not, what exactly are we waiting for?
I would love it if we could merge the code soon. I, too, would like to hear from our mentors regarding the licensing. AFAIK, Apache projects can use BSD or similarly licensed code, with a proper note about it in the LICENSE file, but I'd want to be sure. Cheers, Nathan
