Here's a Github compare with .clang-format file and the results when
clang-format-9 is run on all the files under sched/:
https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched
If anyone has comments or observations I would love to know them.
That is horrible! Not even close. It is doing massive corruption of
the original files. I appreciate that this is a work in progress, but
it is not close enough yet for any kind of review. At present, it just
does massive corruption of files.
* It is destroying indentation randomly (like line 71 of clock.h).
* It is destroying the careful alignment of prototypes like line 90
and beyond.
* It removes all vertical alignment, some optional and some required.
* This is crazy. It moved a left bracket onto the same line as a
definition (line 54 of clock_dow.c)
* in clock_systimer.c, pre-processor definitions must not be indented
when use in the code section (numerous places).
https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#indentation
* in clock_systimespec.c, line 134. The indentation was correct. The
tool ruined it. Also line 142 it again destroys the proper
alignment of the first line of C comment blocks. Numerous other places.
* in clock_timekeeping.c, line 88 abd line 105 spurious destruction of
vertical alignment.
* And on an on.. There is too much there to review.
We agreed when we started this that the success criteria was no
differences from the original. I could see compromising a few find
details, but this is not close. This is the worst formatting
programming I have seen. All of the formatters under tools are better
and none of them are acceptable.
I don't know if these can be fixed or not but please do not commit
anything now. This is not ready. It is just too wrong and I would not
want anyone to use it.
