Why would you merge it to branch it is not ready? This is not hard.
The PR will not pass CI if it fails Style check. Period! That is a simple check. We should have that by now. Also add it to the commit hooks locally. (document the work flow and add the script to download it - or put it in the build make checks it and ask to install it) The problem solved by workflow and tools. -----Original Message----- From: Gregory Nutt [mailto:spudan...@gmail.com] Sent: Thursday, March 05, 2020 9:32 AM To: dev@nuttx.apache.org Subject: Re: squashing commits or not One big problem that I encounter is that people change .c and .h files but do not run nxstyle against the resulting files. It is not really possible to verify that online (currently, hopefully soon, however). So you don't know about the stylistic problems until you have already merged onto a branch. In that case, your commits WILL be modified. No modifed .c or .h files may come into the repository without passing nxstyle. So, if contributors don't want people mucking with the changes, please run nxstyle before creating the PR. Otherwise, you will have to live with the consequences. We are currently operating under the old workflow of the pre-Apache Bitbucket days. That will transition to the Apache workflow at some point in the future when the tools, triggers, and documentation are in place. They are not now. The old workflow is that I basically do whatever the hell I want to. That can be fixed by getting tools, processes, documentation, and wider participation in place. So currently, if you don't like things, too bad. so sad.
