The point I'd like to make, is that I'd much rather the whole world stop
turning, nothing get merged into master until we sort out the process;
rather than allow anything to break master. I'd like for us to adopt a
philosophy that "Nothing is worse than breaking Master." Now, that's
just
me, I welcome counterarguments (and even flames).
Nothing in the process is particularly different at present than in
the past. Several unverified PRs came in close together in time.
Since each broke the build and were separated over time, the build
remained broken for a couple weeks or more.
There is nothing significantly different in the process from when when
patches were added in the same manner. Users are simply not acting
responsibly right now and are not verifying the changes before
committing them (it appears, in cases, that they are not even
compiling them!). That behavior has to stop.
We were just luckier in the past and I think people were more careful
when they had to work up patches vs. just pushing a button to create a
PR. The ease of creating PRs with one finger leads to sloppiness.
That being said, the solution is the same: We need automated checks to
assure, at a minimum, that there is no build breakage. But there is no
new crisis. This is the same situation as in the past.
So I see no real reason to do anything differently except to ask people
to please very the changes before you push the button and submit the
PR. We aren't in that big of a rush. Test it, build it. Get some
confidence first. Then, and only then, fire off the PR.
Meanwhile, in parallel we can get some automated verification in place.
Greg
