On Tue, Jan 7, 2020 at 5:09 PM Gregory Nutt <spudan...@gmail.com> wrote:
>
> The removal of (void) from all functions whose return value has been
> ignored has introduced several new warnings into the build test output.
> For example in lpc3_appinit(), I now see this:
>
>     #  define nsh_spifi_initialize() (OK)
>
> and
>
>     nsh_spifi_initialize();
>
> which now generates a new warning:  "warning: statement with no effect
> [-Wunused-value]"

So I guess our choices are:

1. Reinstate (void) only where the warning occurs.

2. Reinstate (void) everywhere return values aren't checked. What a nightmare.

3. Change defines such as the above to static inline functions.
Disadvantage: The inline keyword is not in the C89 standard.

Nathan

Reply via email to