On Wed, Jan 8, 2020 at 12:01 PM Gregory Nutt <spudan...@gmail.com> wrote:
>
>
> >> Since code check part is available now, could I and Duo prepare to setup
> >> Jenkins CI job firstly?
> >> At fist, start to do the PR check stage according to the workflow option
> >> chosen, then go to the build stage in the next couple of days.
> >> We could optimize all the stages step by step once we start working
> >> on it :
> >> )
> >
> > He should talk about how this would be implemented.
> >
> > In the past, we talk about trying to keep as much of the test support
> > files out of the nuttx/ and apps/ repositories as possible. I would
> > prefer that we try to keep those repositories as clean as possible
> > with little or not testing files.
> >
Yes, all Jenkins related files should put on the Jenkins server as
much as possible.
> > We talking about a third testing/ repository that would be an
> > environment for testing. In that repository, you could support the
> > nuttx/ and apps/ directories as submodules and have an environment
> > that could support unlimited testing without contaminating the nuttx/
> > and apps/ end-user directories.
> >
> > Can we please consider this? Let's not put any Jenkins CI in those
> > end-user directories.
>
Let's see whether the submodule is needed during the development. But
the principle is that: submodule should be used only for
building/testing verification, the user/contributor don't need to know
anything about submodule.
> DavidS also suggested moving some of the common tools, such as nxstyle,
> out of nuttx/tools to testing/tools. The coding standard check is not
> specific to the nuttx/ repository.
>
But, most user also need these tools to ensure that they don't break
the rule before submit PR.
Basically, we have two catagory tools:
1.The workflow independent scripts, like checkpatch.sh and testbuild.sh
These tools can run standalone in the developer machine, and very
usefull for their daily work. The best location is nuttx/tools folder.
2.The workflow dependent scripts
The best location for these tools is the Jenkins server.
> Greg
>
>
