We have two options:
1.Ensure the changed/new code comply with the coding standard
2.Ensure the whole modified file comply with the coding standard
If the community like the 2nd option, I am fine.
I can tell you how I did this in the past as the single committer. In
the last year or so, nxstyle has become stable enough to use as part of
the code review process.
1a. I would apply patches, or
1b. In the case of PRs, merge the PR, then
2. I ran nxstyle against every file modified by the change, and
3. I fixed the code to resolve every nxstyle complaints then
4. pushed the code upstream.
Let's call this option 3. The difference between options 1 and 2 and
option 3 is the I did all of the changes to make the contribution
compliant to the coding standard, not the contributor. It is really
easier and more efficient to do it yourself than it is to keep hassling
a user to get the coding standard right.
But I appreciate that others would not want to do things this way. And
contributors don't learn anything about the coding style. But I thought
you should know.
Greg
