davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361979138
##########
File path: tools/nxstyle.c
##########
@@ -1896,24 +1962,32 @@ int main(int argc, char **argv, char **envp)
else if (indent == 1 || indent == 3)
{
- fprintf(stderr, "Small odd alignment at line %d:%d\n",
- lineno, indent);
+ ERROR("Small odd alignment", lineno, indent);
}
}
}
}
if (!bfunctions && !hdrfile)
{
- fprintf(stderr, "ERROR: \"Private/Public Functions\" not found!\n");
- fprintf(stderr, " File could not be checked.\n");
+ FATAL("\"Private/Public Functions\" not found!"
+ " File was not be checked", lineno, 1);
}
if (ncomment > 0 || bstring)
{
- fprintf(stderr, "ERROR: In a comment/string at end of file\n");
+ FATAL("Comment or string found at end of file", lineno, 1);
Review comment:
```suggestion
ERROR("Comment or string found at end of file", lineno, 1);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
