xiaoxiang781216 commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568532088 > > Yes, but we already have the rule in tools/Makefile.host for generating nxstyle binary, the question is where should we trigger the target. It's better to let the script trigger the buildotherwise user can't invoke the tool outside the make environment(e.g. from jenkins job, precommit hook or command line). > > Why is the building of the host tools not part of the top level make process? Shouldn't the host tools be built So that there is a sane environment prior to building the config target? Because user may run the script without issue any make command first, for example: The jenkins job could run the script check the style before build to save the time. As Greg indicate, we can build nxstyle with one line command: make -C tools -f Makefile.host nxstyle But it's very helpful to issue the above command in the script, because many user even expert don't know this trick.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
