xiaoxiang781216 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360904297
########## File path: tools/Makefile.unix ########## @@ -324,6 +324,14 @@ tools/cnvwindeps$(HOSTEXEEXT): # $(Q) echo "No .config file found, creating one" # $(Q) tools/initialconfig$(HOSTEXEEXT) +# make it easy to see what is happening +COLOR_BLUE = \033[0;94m Review comment: @davids5 I would prefer we work on check_code_style.sh first, and forget Makefile.unix at all. Why? this avoid we couple the script logic with Makefle, for example: 1.The above implementation make the standalone script can't colorize the output. 2.The dependence rule can't work if user invoke the script from shell directly. The best aproach is that we focus on the script development and make it work from command line as we want, then we can integrate the script either as the make target or precommit hook. Otherwise, the script will do a major rework for the standalone case. Invoking the script from command line is the key feature for this tool, becasue we need integrate this tool into various workflow(e.g. Makefile, precommit hook, jenkins job). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
