[
https://issues.apache.org/jira/browse/NUTCH-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404804#comment-16404804
]
ASF GitHub Bot commented on NUTCH-2539:
---------------------------------------
sebastian-nagel commented on a change in pull request #300: NUTCH-2539
URL: https://github.com/apache/nutch/pull/300#discussion_r175433990
##########
File path: conf/nutch-default.xml
##########
@@ -548,15 +548,18 @@
</property>
<property>
- <name>db.url.normalizers</name>
+ <name>crawldb.url.normalizers</name>
<value>false</value>
Review comment:
crawldb.url.normalizers is also overwritten from command-line (`updatedb ...
-normalize`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Not correct naming of db.url.filters and db.url.normalizers in
> nutch-default.xml
> --------------------------------------------------------------------------------
>
> Key: NUTCH-2539
> URL: https://issues.apache.org/jira/browse/NUTCH-2539
> Project: Nutch
> Issue Type: Improvement
> Affects Versions: 1.15
> Reporter: Semyon Semyonov
> Priority: Major
>
> There is a mismatch between config and code.
> In code,
> In CrawlDbFilter line 41:43
> > public static final String URL_FILTERING = "crawldb.url.filters";
> > public static final String URL_NORMALIZING = "crawldb.url.normalizers";
> > public static final String URL_NORMALIZING_SCOPE =
> > "crawldb.url.normalizers.scope";
>
> In nutch-default.xml
> > <property>
> > <name>db.url.normalizers</name>
> > <value>false</value>
> > <description>Normalize urls when updating crawldb</description>
> > </property>
> >
> > <property>
> > <name>db.url.filters</name>
> > <value>false</value>
> > <description>Filter urls when updating crawldb</description>
> > </property>
> These properties should be in line with code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
