+1 (binding) Verified signatures and hashes.
Built NiFi on Ubuntu 24.04 with Java 8 (Zulu 8.82.0.21-CA-linux64 build 1.8.0_432-b06) and Maven 3.9.9 with empty local repo. Started up NiFi in secure / unsecure mode on Java 8. Ran some simple flows. Checked if DISCLAIMER is present in the zip bundles. Thanks for RMing Ferenc! Regards, Peter Turcsanyi On Sun, Nov 17, 2024 at 1:50 PM Krisztina Zsihovszki <zsikr...@gmail.com> wrote: > +1 (non-binding) > > - Verified signatures and hashes > - Ran build using Maven 3.9.3 > - Ran build on macOS 14.5 with 8.0.392-zulu, unit tests passed > - Tested some basic flows > > Thanks Ferenc for RMing. > > > > On Sun, Nov 17, 2024 at 3:11 AM Mark Bean <mark.o.b...@gmail.com> wrote: > > > +1 (non-binding) > > > > Verified checksums and hash. > > Built with: > > Apache Maven 3.9.6 > > Java version: 1.8.0_432 > > > > Performed upgrade of simple flow from 1.26.0 and its proper operation. > > Confirmed upgrade of > > Netty to 4.1.115.Final > > aws-java-sdk to 1.12.778 > > > > Not worth sinking the release, but I found that some of the > .versionsBackup > > files still exist: > > > > > ./nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-common/pom.xml.versionsBackup > > > ./nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-nar/pom.xml.versionsBackup > > > > > > > ./nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/pom.xml.versionsBackup > > ./nifi-nar-bundles/nifi-grpc-bundle/pom.xml.versionsBackup > > > > This often occurs when not including the profile, -Pinclude-grpc > > > > > > On Fri, Nov 15, 2024 at 12:37 PM Nissim Shiman <nshi...@yahoo.com.invalid > > > > wrote: > > > > > Thank you Ferenc, Dan, Pierre and David for clarifying the Netty > > upgrade. > > > > > > > > > +1 (non-binding) > > > > > > > > > checksums are good > > > > > > Compiled with > > > Apache Maven 3.9.9 1.8.0_432 (openjdk) RHEL 8 > > > > > > Verified DISCLAIMER is at root of nifi and nifir-registry installations > > > (NIFI-13970) > > > Verified Netty jars are at version 4.1.115.Final (NIFI-13993) > > > > > > Ran some basic flows Upgraded nifi registry (with pre-existing > versioned > > > flows) from 1.27 to 1.28.1 successfully. Created new PGs from > versioned > > > flows. Pushed new versions of flows to registry. > > > > > > > > > Thank you Ferenc and team for the upcoming release. > > > > > > Thanks, > > > Nissim Shiman > > > > > > > > > On Friday, November 15, 2024 at 03:12:18 PM UTC, Dan S < > > > dsti...@gmail.com> wrote: > > > > > > David, > > > Thank you for clarifying that. > > > > > > On Fri, Nov 15, 2024 at 10:08 AM David Handermann < > > > exceptionfact...@apache.org> wrote: > > > > > > > Dan, > > > > > > > > As Pierre noted, the Netty upgrade to 4.1.115 is included in the RC3 > > > > release branch, covered under the release issue NIFI-13993. > > > > > > > > Regards, > > > > David Handermann > > > > > > > > On Fri, Nov 15, 2024 at 9:07 AM Dan S <dsti...@gmail.com> wrote: > > > > > > > > > > DIdn't David Handermann down vote the previous vote in order to > have > > > the > > > > > Netty change made before releasing? > > > > > > > > > > On Fri, Nov 15, 2024 at 10:02 AM Ferenc Kis < > briansolo1...@gmail.com > > > > > > > wrote: > > > > > > > > > > > There were some other changes on the release branch. My intention > > was > > > > > > to collect them into one commit and submit a PR against > support/1.x > > > > > > after the 1.28.1 release happened > > > > > > > > > > > > On Fri, Nov 15, 2024 at 3:52 PM Dan S <dsti...@gmail.com> wrote: > > > > > > > > > > > > > > I can take care of this. > > > > > > > > > > > > > > On Fri, Nov 15, 2024 at 9:22 AM Nissim Shiman > > > > <nshi...@yahoo.com.invalid > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Team, > > > > > > > > > > > > > > > > I'm not sure if the Netty upgrade PR > > > > > > > > https://issues.apache.org/jira/browse/NIFI-14010 has been > > > > backported > > > > > > the > > > > > > > > to the 1.28.x branch yet. > > > > > > > > > > > > > > > > > > > > > > > > Do we still want this now or is getting in before the final > > Dec 8 > > > > build > > > > > > > > good enough? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Nissim > > > > > > > > > > > > > > > > > > > > > > > > On Friday, November 15, 2024 at 10:47:06 AM UTC, Ferenc > Kis > > < > > > > > > > > briansolo1...@apache.org> wrote: > > > > > > > > > > > > > > > > Team, > > > > > > > > > > > > > > > > I am pleased to be calling this vote for the source release > of > > > > Apache > > > > > > > > NiFi 1.28.1. > > > > > > > > > > > > > > > > Please review the following guide for how to verify a release > > > > candidate > > > > > > > > build: > > > > > > > > (please use "export VERSION=1.28.1" in Verification Steps > > > section) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification > > > > > > > > > > > > > > > > The source being voted on the and the convenience binaries > are > > > > > > > > available on the Apache Distribution Repository: > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/nifi/nifi-1.28.1 > > > > > > > > > > > > > > > > The build artifacts are available on the Apache Nexus > > Repository: > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachenifi-1301 > > > > > > > > > > > > > > > > Git Tag: nifi-1.28.1-RC3 > > > > > > > > Git Commit ID: 883338fe28883733417d10f6ffa9319e75f5ea06 > > > > > > > > GitHub Commit Link: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/nifi/commit/883338fe28883733417d10f6ffa9319e75f5ea06 > > > > > > > > > > > > > > > > Checksums of nifi-1.28.1-source-release.zip > > > > > > > > > > > > > > > > SHA256: > > > > > > 7a7a0840c08011cdbc6e234781b551b1b0fa2dfd0b24f06cb1758a043b8cd855 > > > > > > > > SHA512: > > > > > > > > > > > > > > > > > > > > > > > > 676c8d4fa0d5d862c0afb7528a9aae9ba022c17b73fcdb0bfbbb8c89f4e62568b42f0426039aabe59c8736c4ab269f00551439c0f57f382eae8f3a52702a9a64 > > > > > > > > > > > > > > > > Release artifacts are signed with the following key: > > > > > > > > > > > > > > > > https://people.apache.org/keys/committer/briansolo1985.asc > > > > > > > > > > > > > > > > KEYS file is available on the Apache Distribution Repository: > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS > > > > > > > > > > > > > > > > Issues resolved for this version: 10 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12355265 > > > > > > > > > > > > > > > > Release note highlights can be found on the project wiki: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.28.1 > > > > > > > > > > > > > > > > The vote will be open for 72 hours. > > > > > > > > > > > > > > > > Please download the release candidate and evaluate the > > necessary > > > > items > > > > > > > > including checking hashes, signatures, build from source, and > > > test. > > > > > > > > Then please vote: > > > > > > > > > > > > > > > > [] +1 Release this package as nifi-1.28.1 > > > > > > > > [] +0 no opinion > > > > > > > > [] -1 Do not release this package because... > > > > > > > > > > > > > > > > > > > > > > > >
