For reference: Netty 4.1 NOTICE https://github.com/netty/netty/blob/4.1/NOTICE.txt Netty 3.7 NOTICE https://github.com/netty/netty/blob/3.7/NOTICE.txt
On Tue, Jun 27, 2017 at 10:21 PM, Tony Kurc <trk...@gmail.com> wrote: > Background, I asked Mike how he put together the LICENSE, and why he added > a separate section in the LICENSE for Google Protocol Buffers 3.3.1, and > his answer that made sense was "well, what existed there was there had a > version (2.5.0)". > > Interesting note, the Google Protocol Buffers LICENSE looks to be the > same. > > Sort of the opposite issue with Netty. NOTICE didn't have a version of > Netty, and the NOTICES between versions were fairly different. > > > > On Tue, Jun 27, 2017 at 10:16 PM, Michael Hogue < > michael.p.hogu...@gmail.com> wrote: > >> Hello all, >> >> I'm attempting to merge a LICENSE and NOTICE i've created for a new >> grpc >> processor bundle [1,2] into the NiFi assembly. I've run into a couple of >> things i don't know how to resolve: >> >> 1. If I add a new (transitive) dependency with a newer version than exists >> elsewhere in the code _and_ the licenses are the same except for the >> version, do the license for each of the versions need spelled out in the >> nifi assembly LICENSE file? >> >> 2. One of the grpc dependencies i've added pulls in a version of netty >> fairly different than what exists in the code already. Should there be a >> separate block in the assembly NOTICE if they differ? Is it sufficient to >> add to the existing netty block? >> >> PR reference: >> https://github.com/apache/nifi/pull/1947/files#diff-c3a3e6d0 >> 27b17e530efdb23269e95968R1132 >> >> Thanks, >> Mike >> >> [1] https://issues.apache.org/jira/browse/NIFI-4037 >> [2] https://issues.apache.org/jira/browse/NIFI-4038 >> > >