+1 - binding Hashes and signature looked good Build, tests, and contrib check good README, L&N look fine Verified some simple flows and operation
Environment: Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c; 2015-03-13T16:10:27-04:00) Maven home: /usr/local/maven Java version: 1.8.0_121, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-0.b13.el7_3.x86_64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.18.17-13.el7.x86_64", arch: "amd64", family: "unix" On Tue, Jun 6, 2017 at 5:55 PM, Yolanda Davis <[email protected]> wrote: > +1 (binding) > > -Ran through release helper > -Full build with contrib check on OSX > -Ran simple flow, worked as expected > > On Tue, Jun 6, 2017 at 1:59 PM, Scott Aslan <[email protected]> wrote: > > > +1 (non-binding) > > > > - Verified signatures, checksums, LICENSE, NOTICE, and README > > - Built using a full clean build with contrib check successfully on OSX > > - Run example data flows on OS X with Chrome Version 58.0.3029.110 > > (64-bit) > > on unsecured instance > > - Run example data flows on OS X with Chrome Version 58.0.3029.110 > > (64-bit) on > > secured instance > > > > On Tue, Jun 6, 2017 at 1:17 PM, Pierre Villard < > > [email protected]> > > wrote: > > > > > +1 (binding) > > > Release this package as nifi-0.7.4 > > > > > > - Ran through release helper, all looks good (build on OSX) > > > - Basic workflows running as expected > > > > > > > > > 2017-06-06 17:44 GMT+02:00 Bryan Bende <[email protected]>: > > > > > > > +1 (binding) Release this package as nifi-0.7.4 > > > > > > > > - Ran through release helper and everything checked out > > > > - Ran basic flow to test that binary works > > > > > > > > Minor note - The years in the NOTICE files still say 2014-2016. > > > > > > > > > > > > On Tue, Jun 6, 2017 at 11:30 AM, Joe Skora <[email protected]> wrote: > > > > > +1 (binding) > > > > > > > > > > * Verified GPG signature. > > > > > * Verified hashes. > > > > > * Built source with contrib-check profile. > > > > > * Verified README, NOTICE, and LICENSE. > > > > > * Verified commit ID. > > > > > * Verified RC was branched from "support/nifi-0.7.x". > > > > > * Ran binary and tested basic functionality. > > > > > > > > > > On Mon, Jun 5, 2017 at 9:29 PM, Koji Kawamura < > > [email protected]> > > > > > wrote: > > > > > > > > > >> +1 (binding) > > > > >> > > > > >> Verified gpg signature. > > > > >> Verified all hashes on source zipfile. > > > > >> Performed mvn clean install -Pcontrib-checks > > > > >> Builds cleanly, all tests pass on Mac OS Sierra (10.12.4) > > > > >> Oracle JDK 1.8.0_121-b13, maven 3.2.5 > > > > >> Ran simple flow and worked as expected. > > > > >> > > > > >> Thanks, > > > > >> Koji > > > > >> > > > > >> On Tue, Jun 6, 2017 at 7:31 AM, Adam Taft <[email protected]> > > wrote: > > > > >> > +1 (binding) > > > > >> > > > > > >> > Verified gpg signature. > > > > >> > Verified all hashes on source zipfile. > > > > >> > Performed mvn clean install -Pcontrib-checks > > > > >> > Builds cleanly, all tests pass in docker container centos:latest > > w/ > > > > >> > openjdk-1.8.0 and maven 3.5.0 > > > > >> > LICENSE, NOTICE, README look good. > > > > >> > Binary runs as expected with a simple dataflow. > > > > >> > > > > > >> > Cheers, > > > > >> > > > > > >> > Adam > > > > >> > > > > > >> > > > > > > > > > > > > > -- > -- > [email protected] > @YolandaMDavis >
