Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/91#issuecomment-167489597
@rickysaltzer Did another review on this and overall things look pretty
good and the issues of bigger concern seem to be corrected. I left an
additional patch on the ticket with some stylistic items and version update
(0.4.2-SNAPSHOT) changes I would like to apply on top of your patch.
My final comments are concerning some of the properties. In the case of
the metric property, this is something that you use as a float to provide in
the transmission to the Riemann server. It would be good to include this in
the property descriptor to make this a little clearer. This should also be
applied to the TTL and time properties. I did some digging to try to figure
out how to flesh this out more, but wasn't quite sure how to best describe
them. If you can provide some additional detail on those and the anticipated
input, it would certainly help. Apologies if this is a misunderstanding on my
behalf, still quite the Riemann novice.
Thanks again for the updates though and with some additional details on the
properties I think we are good to go! Thanks for all your efforts!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
