[ 
http://jira.codehaus.org/browse/MOJO-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256980#action_256980
 ] 

Sean Flanigan commented on MOJO-1582:
-------------------------------------

Thanks, well, I am getting the same output as of the latest snapshot, but I do 
think a couple of bugs are showing.  

Although there's no sign of the NPE, the branch should be 'default', not 
UNKNOWN.  

Also, it's using the wrong filename when checking for local modifications.   
The message you got: "Not a file: 
/home/olamy/dev/test-projects/flies/common/flies-common-api/flies-parent/pom.xml.
 Ignoring" is because it should have checked the file 
{{/home/olamy/dev/test-projects/flies/flies-parent/pom.xml}}, not 
{{/home/olamy/dev/test-projects/flies/common/flies-common-api/flies-parent/pom.xml}}.
  As I said, I think a relative path was used relative to the pom directory, 
rather than the hg root directory.

> Uniform interface/goal for all supported SCM providers
> ------------------------------------------------------
>
>                 Key: MOJO-1582
>                 URL: http://jira.codehaus.org/browse/MOJO-1582
>             Project: Mojo
>          Issue Type: Improvement
>          Components: buildnumber
>    Affects Versions: buildnumber-maven-plugin-1.0-beta-4
>            Reporter: Andreas Sewe
>            Assignee: Olivier Lamy
>             Fix For: buildnumber-maven-plugin-1.0-beta-5
>
>
> At the moment, there are two goals: {{buildnumber:create}} and 
> {{buildnumber:hgchangeset}}. But this is a leftover from MOJO-1432 being 
> contributed as a new goal rather than extending the existing one.
> All properties defined by {{buildnumber:create}} ({{buildNumber}}, 
> {{timeStamp}}, and {{buildScmBranch}}) are meaningful for Mercurial (and 
> possibly other SCMs) as well. Why do they have to be called differently 
> ({{changeSet}} and {{changeSetDate}})? This way one has to remember to change 
> the plugin configuration when one switches to another SCM (which shouldn't 
> IMHO require changes beyond the {{<scm>}} element). This is particularly 
> annoying as one cannot simply configure the {{buildnumber-maven-plugin}} in 
> an organisational parent POM, if some of the organisation's child projects 
> use one SCM and some use another.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to