[
http://jira.codehaus.org/browse/MSQL-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=207052#action_207052
]
Robert Scholte commented on MSQL-47:
------------------------------------
I've had a small look at your code.
Some suggestions:
- Once a comment or quote (single or double) has started, loop within that
section untill it ends. This way you will get rid of those flags as well, and
it's probably more solid.
- There's already a dependency to plexus-utils, why not make use of it's
StringUtils?
> Syntax error if "--" is in escaped strings in sourced sql files
> ---------------------------------------------------------------
>
> Key: MSQL-47
> URL: http://jira.codehaus.org/browse/MSQL-47
> Project: Maven 2.x SQL Plugin
> Issue Type: Bug
> Environment: linux, maven 2.2.1, mysql 5.1.37, java 1.6.0_17
> Reporter: Ronald Steininger
> Assignee: Mark Struberg
> Priority: Minor
> Attachments: MSQL-47.patch, sql-maven-plugin-test.tgz
>
>
> see attached maven project.
> I get an syntax error if testcase.sql gets sourced via sql-maven-plugin. Said
> sql script works if sourced via mysql <testcase.sql
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
