[
http://jira.codehaus.org/browse/MASPECTJ-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David J. M. Karlsen updated MASPECTJ-75:
----------------------------------------
Assignee: David J. M. Karlsen
Remaining Estimate: 0 minutes
Original Estimate: 0 minutes
> The plugin should be more verbose regarding compiling / weaving - similar to
> the Maven compiler plugin
> ------------------------------------------------------------------------------------------------------
>
> Key: MASPECTJ-75
> URL: http://jira.codehaus.org/browse/MASPECTJ-75
> Project: Mojo AspectJ Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Torsten Juergeleit
> Assignee: David J. M. Karlsen
> Original Estimate: 0 minutes
> Remaining Estimate: 0 minutes
>
> Currently the plugin doesn't log enough information in non-debug mode:
> * no hint is given why compiling / weaving isn't triggered
> * if compiling / weaving is triggered then the number of (aspect) source
> files should logged
> The AspectJ plugins logging should be similar to the standard Maven compiler
> plugin.
> This can be fixed easily in {{AbstractAjcCompiler.execute()}}:
> {code}
> Index: src/main/java/org/codehaus/mojo/aspectj/AbstractAjcCompiler.java
> ===================================================================
> --- src/main/java/org/codehaus/mojo/aspectj/AbstractAjcCompiler.java
> (revision 10299)
> +++ src/main/java/org/codehaus/mojo/aspectj/AbstractAjcCompiler.java
> (working copy)
> @@ -309,7 +309,7 @@
> ArtifactHandler artifactHandler =
> project.getArtifact().getArtifactHandler();
> if ( !"java".equals( artifactHandler.getLanguage() ) )
> {
> - getLog().debug( "Not executing aspectJ compiler as the project
> is not a Java classpath-capable package" );
> + getLog().warn( "Not executing aspectJ compiler as the project is
> not a Java classpath-capable package" );
> return;
> }
>
> @@ -320,17 +320,17 @@
>
> if ( !hasSourcesToCompile() )
> {
> - getLog().debug( "No sources found skipping aspectJ compile" );
> + getLog().info( "No sources found skipping aspectJ compile" );
> return;
> }
>
> if ( !isBuildNeeded() )
> {
> - getLog().debug( "No modifications found skipping aspectJ
> compile" );
> + getLog().info( "No modifications found skipping aspectJ compile"
> );
> return;
> }
>
> - getLog().debug( "Starting compiling aspects" );
> + getLog().debug( "Compiling and weaving " + resolvedIncludes.size() +
> " sources to " + getOutputDirectories().get( 0 ) );
> if ( getLog().isDebugEnabled() )
> {
> String command = "Running : ajc ";
> @@ -351,7 +351,7 @@
> }
> catch ( IOException e )
> {
> - throw new MojoExecutionException( "Could not write arguments
> file to the target area" );
> + throw new MojoExecutionException( "Could not write arguments
> file to the target area", e );
> }
> Main main = new Main();
> MavenMessageHandler mavenMessageHandler = new MavenMessageHandler(
> getLog() );
> {code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
