[
http://jira.codehaus.org/browse/MOJO-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=186451#action_186451
]
Jochen Wiedmann commented on MOJO-1150:
---------------------------------------
I understand your intention and it certainly makes sense. However, I am not
ready to review a patch file of 39k, considering that the actually required
changes are most likely not so big. Please resubmit a patch, which contains
only necessary changes and not a lot of beautifications or whatever you name it.
> Make xml-maven-plugin validate only modified files
> --------------------------------------------------
>
> Key: MOJO-1150
> URL: http://jira.codehaus.org/browse/MOJO-1150
> Project: Mojo
> Issue Type: Improvement
> Components: xml
> Reporter: Piotr Kubowicz
> Assignee: Jochen Wiedmann
> Attachments: xml-cache-validation.patch
>
>
> As issue http://jira.codehaus.org/browse/MOJO-1120 says, validating XML for
> well-formedness using the xml-maven-plugin is very slow. A quite obvious
> solution for this is to validate only these files, which have been changed.
> xml-maven-plugin already includes code which does such job: Translate task
> checks file dates. So the job is only to adopt this mechanism to Validate
> task.
> I have created a patch adding checking of file date to ValidateMojo, and
> moving some reusable code away from TransformMojo. Perhaps it's not the most
> ellegant way of implementing this, but it works. The patch does not break any
> tests, however, it would be very desirable to write unit tests for this new
> feature (I haven't done this).
> I have commented out some logging code in FileUtil (new class extracted from
> ValidateMojo, including reusable code), because I was not sure which logging
> implementation you use. You can easily uncomment and make logging working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
