> I came across this posting of yours, regarding your patch for
> buildnumber-maven-plugin:
> http://www.mail-archive.com/[email protected]/msg15562.html
>
> That's very cool! This is something I'd love to have as well... would you
> mind letting me know the best way to get/use the patch.

Hi Aaron,

The patch was accepted upstream:
http://jira.codehaus.org/browse/MOJO-1379

I suppose the next thing would be to kindly ask Paul (or someone) to
cut a release.

I'm not sure if this is a bug or even matters to most folks, but if
you're trying to use the "branch" functionality of
buildnumber-maven-plugin in a directory that isn't in the top-level of
your working copy, the branch string may be unexpected/inaccurate. The
attached patch demonstrates the problem, but I'm not sure how to fix
the regex in CreateMojo.java so the new "scmBranchDeep" assert passes.

Best,
-Adam
Index: src/test/java/org/codehaus/mojo/build/TestCreateMojo.java
===================================================================
--- src/test/java/org/codehaus/mojo/build/TestCreateMojo.java	(revision 10109)
+++ src/test/java/org/codehaus/mojo/build/TestCreateMojo.java	(working copy)
@@ -135,5 +135,7 @@
     	assertEquals("branches/v1.2.x", mojo.filterBranchFromScmUrl(scmUrlBranch));
     	String scmUrlTag = "https://mifos.dev.java.net/svn/mifos/tags/v1.2.1";;
     	assertEquals("tags/v1.2.1", mojo.filterBranchFromScmUrl(scmUrlTag));
+    	String scmBranchDeep = "https://mifos.dev.java.net/svn/mifos/branches/v1.3.x/application";;
+    	assertEquals("branches/v1.3.x", mojo.filterBranchFromScmUrl(scmBranchDeep));
     }
 }
---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to