Hi there,

The mojo-parent Checkstyle configuration [1] uses the JavadocPackage
check, which is new in 5.0, but the POM specifies
maven-checkstyle-plugin 2.2 which uses Checkstyle 4.4.  This means
that site generation fails for any plugin that uses this parent.

MCHECKSTYLE-105 introduced the Checkstyle 5 dependency on the Maven
checks; should this have been done since maven-checkstyle-plugin 2.3
is not released yet?  Checkstyle should really be configured by using
a versioned artifact to bring in its configuration, otherwise
previously successful builds can fail in future as they reference the
trunk.

So to fix we can either:
1) rollback the 5.0-specific changes to maven_checks.xml
2) release maven-checkstyle-plugin, update and release mojo-parent accordingly
3) change mojo-parent to bring in the Checkstyle configuration via a
versioned artifact and release

I'd prefer (3) which is pretty simple.  I've just tried this locally
and it simply involves changes the configuration file URLs to resource
paths, which are provided by the maven-checkstyle-plugin itself and
are thus versioned.

Any objections to me committing this change to mojo-parent?

Cheers,

Mark

[1] 
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to