[ 
http://jira.codehaus.org/browse/MOJO-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167869#action_167869
 ] 

Dirk Olmes commented on MOJO-1303:
----------------------------------

The flaw you discovered is actually more in my usage of the plugin than in the 
patch itself. I totally agree with you that building a child project 
stand-alone will not be possible if only the toplevel pom reads the properties 
file.

I still think that the patch is valid: the promise of the properties plugin is 
to behave the same way as if properties were specified in a POM file. If you 
specify a property in a POM file, that propery is available to the module plus 
all its submodules. If I read in properties using the plugin, the read 
properties are only available in the module that reads the properties.

I see how your settings module approach could help my build, too so that would 
make an excellent addition, too. I'd be glad to help out if you need testing, 
reviewing etc.

> read-project-properties in parent pom does not make the properties accessible 
> for child modules
> -----------------------------------------------------------------------------------------------
>
>                 Key: MOJO-1303
>                 URL: http://jira.codehaus.org/browse/MOJO-1303
>             Project: Mojo
>          Issue Type: Bug
>          Components: properties
>            Reporter: Dirk Olmes
>            Priority: Critical
>         Attachments: projects-with-plugin.zip, projects-with-property.zip, 
> ReadPropertiesMojo.patch
>
>
> Declaring a property in a parent pom (reactor build) makes it available for 
> all child modules. Reading in properties using the read-project-properties 
> goal fails to make the properties read from the file available in child 
> modules.
> I have attached two sets of poms demonstrating the bug: if you build the 
> contents of projects-with-property.zip the final name of the baz1 jar will 
> include the value of the declared property. If you build the contents of 
> projects-with-plugin.zip the final name of the bar1 jar will not include the 
> value of the read property.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to