and I since Maven does not understand truezip's File interface, i have to use String.
-D On Wed, Jan 14, 2009 at 10:19 PM, Dan Tran <[email protected]> wrote: > I fixed most of the issues, tests pass on both windows and linux with > java4 since inline more issue that cannot be fixed > > On Wed, Jan 14, 2009 at 11:13 AM, Benjamin Bentmann > <[email protected]> wrote: >> Dan Tran wrote: > >> >>> I would like to call a vote to graduate this plugin and release its >>> first beta release. >> >> +0, not using it. Notes: >> >> Many of the source files I looked at had no svn props, especially >> svn:eol-style=native would be handy. >> >> "mvn docck:check" reports >>> >>> [ERROR] Parameter: 'verbose' in mojo: 'remove' is missing a description. >>> [ERROR] Parameter: 'verbose' in mojo: 'copy' is missing a description. >> >> The site.xml could be trimmed down. >> >> In case TrueZipFileSetManager was forked long before file-management:1.2.1, >> it could be worth to check some of the issue fixed [0] and re-sync the >> source. >> >> The "Plugin Documentation" states a bad JDK requirement [1]. This is a >> regression introduced by the mojo-parent:19, more precisely the property >> project.build.java.target that I added in this version. Maven 2.x isn't >> interpolating it, it's only evaluated by the >> PluginParameterExpressionEvaluator when configuring a mojo but that's too >> late for the Maven Plugin Plugin. Until a new mojo-parent is released, the >> workaround is to explicitly configure the JDK requirement as in r8672 [2]. >> > > What should I do with this? > >> Various mojos are annotated with >> @phase="process-resources" >> which contains a typo, should be >> @phase process-resources >> >> The MoveMojo uses java.lang.String for its path parameters "from" and "to". >> This is error-prone with regard to relative paths [3]. The same issue should >> apply to the Fileset bean whose pathnames are of type String, i.e. don't get >> basedir-aligned if users supply relative paths. >> > This is not possible since I can't use java.io.File, i can only use > the one from TrueZip > > do you have a work around? > >> Initially, all the ITs failed for me because of a bad artifactId for the >> plugin in common.xml: >> <artifactId>true-maven-plugin</artifactId> >> note the missing "zip" after "true". >> >> Once I locally fixed that, I ended up with remove-file-in-jar-under-war >> failing due to >>> >>> LifecycleExecutionException: 'list2' was specified in an execution, but >>> not found in the plugin >> >> Also, remove-it failed with >>> >>> ERR: SCRIPT FAILED: java.lang.AssertionError: Expression: (list =~ >>> .*META-INF.maven.org.codehaus.mojo.truezip-maven-plugin-test.pom.xml.*). >>> Values: list = 0 14.01.2009 19:58:02 META-INF\ >>> 0 14.01.2009 19:58:02 META-INF\maven\ >>> 0 14.01.2009 19:58:02 >>> META-INF\maven\org.codehaus.mojo.truezip.it\ >>> 0 14.01.2009 19:58:00 >>> META-INF\maven\org.codehaus.mojo.truezip.it\truezip-maven-plugin-test\ >>> 3.079 14.01.2009 18:18:04 >>> META-INF\maven\org.codehaus.mojo.truezip.it\truezip-maven-plugin-test\pom.xml >>> 123 14.01.2009 19:58:00 META-INF\MANIFEST.MF >>> ERR: ERR: java.lang.AssertionError: Expression: (list =~ >>> .*META-INF.maven.org.codehaus.mojo.truezip-maven-plugin-test.pom.xml.*). >>> Values: list = 0 14.01.2009 19:58:02 META-INF\ >>> 0 14.01.2009 19:58:02 META-INF\maven\ >>> 0 14.01.2009 19:58:02 >>> META-INF\maven\org.codehaus.mojo.truezip.it\ >>> 0 14.01.2009 19:58:00 >>> META-INF\maven\org.codehaus.mojo.truezip.it\truezip-maven-plugin-test\ >>> 3.079 14.01.2009 18:18:04 >>> META-INF\maven\org.codehaus.mojo.truezip.it\truezip-maven-plugin-test\pom.xml >>> 123 14.01.2009 19:58:00 META-INF\MANIFEST.MF >> >> Could that be due to the different path separators on Windows? >> >> More strangely, on WinXP with Sun JDK 1.4.2_16, I see all the ITs failing >> with >>> >>> >>> de.schlichtherle.io.archive.spi.AbstractArchiveDriver$InconsistentCharsetSupportError: >>> The character set 'IBM437' is supported by the JSE 1.1 API, but not the J2SE >>> 1.4 API. >> >> Switching to Java 1.5+ works. Haven't tested Ubuntu so not sure whether this >> is completely caused by Java 1.4 or the combo with Windows. In the first >> case, the JDK requirement should be properly declared on the site. Otherwise >> this might be the plugin's first FAQ entry. >> >> >> Benjamin >> >> >> [0] http://jira.codehaus.org/browse/MSHARED/fixforversion/14544 >> [1] http://mojo.codehaus.org/truezip-maven-plugin/plugin-info.html >> [2] http://fisheye.codehaus.org/changelog/mojo/?cs=8672 >> [3] >> http://maven.apache.org/plugin-developers/common-bugs.html#Resolving_Relative_Paths >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> >> > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
