Hi benjamin

thank you for your analysis

I'll take account about your remarks.

Best regards

David
2008/7/25, Benjamin Bentmann <[EMAIL PROTECTED]>:
>
> david vicente wrote:
>
>  I would like to perform the first release of the Dashboard Maven Plugin.
>>
>
> 0, not using it. Notes:
>
> The POM contains no <scm> element, causing a bad "Source Repository"
> report.
>
> The POM defines remote repositories. If these are not required, they could
> be deleted to avoid their maintenance.
>
> Also, I believe you can delete <project>/<organization> from the POM which
> should be inherited from the Mojo parent.
>
> The <project>/<url> element in the POM erroneously points to the Mojo
> homepage, not the plugin homepage.
>
> "mvn dependency:analyze" shows some undeclared dependencies.
>
> The site descriptor can be trimmed down, i.e. some things are inherited
> [0].
>
> The plugin declares a dependency on plexus-utils:1.3 but has only a
> prerequisite on Maven 2.0.4. If the plugin doesn't work with
> plexus-utils:1.1, you should update the prerequisite to 2.0.6 [1].
>
> Checkstyle/PMD reports a few violations, mostly formatting and javadoc. But
> there are also things like missing hashCode() implementation to accompany
> equals() which might be worth to have a look it.
>
> Some POM snippets in the documentation are a little hard to read because of
> the mixed usage of tabs and spaces for their indentation.
>
> Bonne chance for the release, hope you have less problems with the Release
> Plugin this time ;-)
>
>
> Benjamin
>
>
> [0] http://mojo.codehaus.org/development/guidelines.html
> [1]
> http://maven.apache.org/guides/plugin/guide-java-plugin-development.html
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>   http://xircles.codehaus.org/manage_email
>
>
>

Reply via email to