Benjamin,  I applied the patch, deployed the snapshot, and updated the site.

Please review.

Thanks

-D

BTW, I did not introduce the removeAll expression, until there is real
need for it.


On Sun, Apr 13, 2008 at 4:27 AM, Benjamin Bentmann
<[EMAIL PROTECTED]> wrote:
> Dan Tran wrote:
> > Since there is little interest with this vote, I am going the extend
> > it 2 more days, if there is no objection I will go forward with the
> > release after that.
> >
>
> Sorry, I just had some a look at it to give you my "go" but it ended in a -1
> due to MBUILDHELPER-6. I attached a patch to the issue for your review in
> case you had a good reason to do the path construction manually.
>
> Some non-critical side notes:
>
> docck:check complains about a missing <description> element in the POM, I
> guess that could be fixed as well. The same text could then be copied to the
> index.apt as the introduction to have it look a little nicer.
>
> Also, you could consider to add an expression="${removeAll}" annotation or
> similar to the mojo parameter "removeAll" to allow its configuration from
> the CLI.
>
>
> Benjamin
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>   http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to