[
http://jira.codehaus.org/browse/MTAGLIST-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Bentmann closed MTAGLIST-26.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.2
Applied with modifications in r6356, thanks Nate!
bq. [...] renaming function argument variables that hide scope of class member
variables.
Fortunately, MCHECKSTYLE-84 made most of these unnecessary. The remaining spots
in {{ReportGenerator}} actually revealed bad design.
bq. These two variables were "protected" scope, so I was able to make them
private for this plugin; however, I am concerned that they were protected for
some other reason
I scanned the sources of Maven and Mojo plugins and couldn't find any
references, so making them private seems quite safe.
bq. I was not able to resolve the method length error in FileAnalyser.java.
Using {{LineNumberReader}} to track the line numbers made the warning disappear
for the moment, but this method really begs for refactoring...
> Clean up checkstyle results
> ---------------------------
>
> Key: MTAGLIST-26
> URL: http://jira.codehaus.org/browse/MTAGLIST-26
> Project: Maven 2.x Taglist Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Nate Stoddard
> Assignee: Benjamin Bentmann
> Priority: Trivial
> Fix For: 2.2
>
> Attachments: MTAGLIST-26.patch
>
>
> Currently there are 4 errrors, 55 warnings, and 6 infos in the checkstyle
> results. None of these failures appear to be major; however, when changes
> are made to the plugin it is difficult to confirm that no new checkstyles
> failures were created. If there are zero checkstyle failures, as there are
> with PDM and CPD reports, then the addition of any failure would be easily
> detected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
