[
http://jira.codehaus.org/browse/MJAVACC-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_121916
]
Benjamin Bentmann commented on MJAVACC-57:
------------------------------------------
bq. If we do include a flag to skip the javacc execution and default it to not
run javacc, I believe backwards compatibility could be maintained with very
little added complexity
One task would be to skip all further steps after the initial JJTree execution,
surely not that hard. Where I still see potential problems regarding
backward-compatibility is the handling of target directories. The old "jjtree"
has only "outputDirectory" which defaults to "<snip>/jjtree". The new
"jjtree-javacc" has "interimDirectory" defaulting to "<snip>/jjtree" and
"outputDirectory" defaulting to "<snip>/javacc". Now, for those users that
previously explicitly specified the "outputDirectory" parameter in the plugin
config, we need to use the new mojo's "outputDirectory" instead of
"interimDirectory" when invoking JJTree to get output files into the intented
location. But if we do that, those users that simply left the param
"outputDirectory" unspecified to use the default location will find their files
in "<snip>/javacc" instead of "<snip>/jjtree". OK, we could fix that by not
having Maven inject the default values into the mojo parameters but set them
ourselves in the mojo depending of the flag but honestly, that's the kind of
code smell that really hurts my eye... or am I missing a cleaner realization
for this flag-thing?
bq. Overall, I think either approach is fine though.
Maybe we could get another/third opinion (from Jesse) to come to a democratic
conclusion.
> Allow jjtree to automatically execute javacc
> --------------------------------------------
>
> Key: MJAVACC-57
> URL: http://jira.codehaus.org/browse/MJAVACC-57
> Project: Maven 2.x JavaCC Plugin
> Issue Type: New Feature
> Components: jjtree
> Reporter: Paul Gier
> Assignee: Benjamin Bentmann
> Fix For: 2.x
>
>
> The common use case for jjtree is to first run the jjtree-mojo and then run
> the javacc-mojo on the output of jjtree. This requires the configuration of
> two mojo executions. It would be nice if the jjtree mojo automatically
> called javacc on it's output by default. This way only one execution would
> be needed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
