Hello Geoffrey

Only when I explicitly add a class in hibernate.cfg.xml like this, that 
class gets a create table statement in the script:
<mapping class="ggg.GggType"/>

-- Can you update to the latest snapshot, and if you still get an error, can
you send me the -X output?



2) It's also a bit stranget that outputDirectory is configured in the 
goal and outputfilename in the configurationTaskProperties. Why not at 
the same place?

IMHO I am not 100% convinced that doing exactly like the ANT plugin and 
doing as much as possible with the configurationTaskProperties was a 
good thing :/

-- It's more to keep a standard because all the goals need an
outputdirectory, so I understand why in ANT they also use outputfilename to
just name the SQL dump. And yes, I understand why you might not be
convinced, but the gain is that the plugin can keep up with the changes made
in the ant plugin; also the transition from someone coming from ANT to MAVEN
is more smoothly. But in my case the point about being able to keep up with 
changes is really a big plus.


3) By default it tries to connect to the database, maybe the default 
should work offline instead as most will want to use it to generate 
their SQL scripts for the SysOps - and changing the database while 
trying to configure it correctly is scary.

-- I would say that's really a valid point. Unless I heard otherwise, I
think I'll just go ahead and change the default.



Thanks for your work & continued help, please don't take my criticism 
badly :) Looking forward to some doc examples.

-- Nah, your feedback is always welcomed. At the end my goal for this plugin
is to make as easy to use as possible, and thanks to feedback like yours,
I'll be able to get there.

Regards

Johann Reyes 



---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to