On 24 June 2013 23:58, Olivier Lamy <ol...@apache.org> wrote:
> 2013/6/25 sebb <seb...@gmail.com>:
>> On 24 June 2013 13:04, Olivier Lamy <ol...@apache.org> wrote:
>>> Hi,
>>> I'd like to release Apache Maven Javadoc Plugin 2.9.1.
>>>
>>> This version contains the code to fix the javadoc security issue after
>>> the javadoc generation.
>>>
>>> We fixed 6 issues:
>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?version=18843&styleName=Text&projectId=11138&Create=Create
>>>
>>> Staging repository: 
>>> https://repository.apache.org/content/repositories/maven-062
>>>
>>> Staging site: 
>>> http://maven.apache.org/plugins-archives/maven-javadoc-plugin-2.9.1/
>>
>> SVN tag?
>
> It's a bit implicit if you know our sources tree

Yes, but it helps to have the URL and especially the revision quoted
in the e-mail.
Tags are supposed to be immutable but frequently are not, so the
revision is necessary.

>>
>> KEYS file?
>
> I believe it's available as most of ASF project at
> svn.a.o/repos/asf/$tlp/project/KEYS

Please quote whatever KEYS file is listed on the source download page
and/or ASF dist directory.
It's important that reviewers can check that end-users have access to
the keys they need to check downloads.

>>
>>> Vote open for 72H
>>>
>>> [+1]
>>> [0]
>>> [-1]
>>
>> The parameter applyJavadocSecurityFix  in the class
>> AbstractJavadocMojo is documented as being @since 2.10.
> Argh good catch I will fix that
>>
>> The Release Notes page on the site is empty.
> ?????
>>
>> There's no NOTICE and LICENSE in SVN at the level of the plugin.
> Those files are in the voted artifacts.
>>
>> The NOTICE file looks wrong to me.
>> It has a spurious blank line at the start.
>> The next line says:
>>     Maven Javadoc Plugin
>> This should be
>>    Apache Maven Javadoc Plugin
> Easy to fix
>>
>> The index.html file in the javadoc jar appears to have the frame bug;
>> certainly it does not contain a "function validURL(url)" line.
> Chicken and egg issue as I need the fix but I'm build the fix.

Or just use Java 1.7.0_25 for the build and Java 1.6 for the compile/test.

> So this will be probably the last javadoc jar we publish :-). At least
> the most (public website has been generated with the fix).
>
> BTW I cancel the release.
>
>>
>> Sorry, but I would have to vote -1 if mine were binding.
>>
>>> Thanks,
>>> --
>>> Olivier Lamy
>>> Ecetera: http://ecetera.com.au
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>
>
>
> --
> Olivier Lamy
> Ecetera: http://ecetera.com.au
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to