patch applied r986189. On 16 August 2010 23:50, Stephen Connolly <[email protected]> wrote: > On 16 August 2010 23:15, sebb <[email protected]> wrote: >> On 16 August 2010 16:00, Stephen Connolly >> <[email protected]> wrote: >>> Does the issue have a patch? >> >> It does now. >> >> Many thanks to Stevo Slavic. >> >>> Does the patch include integration tests that cover positive and >>> negative testing? >> >> AFAIK. >> >>> Is the patch against the latest code base? >> >> AFAIK. >> >>> Is the patch formatted using the Maven code style? >> >> AFAIK. >> >>> Does the patch exclude formatting changes on lines not affected by the >>> patch? >> >> Yes. >> >>> If the answer is yes to all of the above then I will apply the patch >>> straight away... If there are no's then you might have to work to >>> find a committer willing to champion your fix. If the answers are all >>> no, then sorry out of luck >> >> I think it's unreasonable to require bug reporters to provide patches. >> Although they are likely to be Java developers, that does not mean >> that they are familiar with Maven plugins or the Maven development >> environment. >> >> That stance may make sense for enhancements, but for a relatively >> simple bug such as this I would expect the developers to be able to >> provide a fix, especially as the faulty code and class had already >> been identified. > > If the bug reporters are complaining about the bug not being fixed, > then it makes sense. This is a volenteer effort, if it's not my itch > I won't scratch it unless you make it easy to do. > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
