[ http://jira.codehaus.org/browse/MNG-1181?page=comments#action_59191 ]
Jochen Wiedmann commented on MNG-1181: -------------------------------------- Jason, I can follow your points, including the "formatted differently". This one wasn't intended, btw, I went as far as creating a special Maven formatter in my Eclipse. However, please understand the following points: - I am not proposing a patch. I am posting a "proof of concept". I am mainly asking for guidance. - Without help, I am most possibly unable to fix the current MavenEmbedder, because it is too complex for me. You're the Maven expert, I am the novice. At least, I won't be able to fix it with a small patch. - I do not even understand the intended lifecycle of the MavenEmbedder, the DefaultMaven, and the objects they are using. - I am happy, if you decide to fix the MavenEmbedder without following my extended proposals. In that case I'll step aside and terminate my work on this request. If you want me to carry on, here's my plan. Understand, that I make the steps as small as possible: - I propose an object (MavenRequestConfiguration?), that may serve as a replacement of the CLI within DefaultMaven. The object will receive additional properties, as required by the MavenEmbedder. This first step doesn't include other changes than proposing this object. - You split the objects properties into two categories: Those, which should be per MavenEmbedder instance and those, which are per request. Additionally, you should provide notes on using these properties, if they have lifcycle considerations, or something similar. - The former properties are removed from the object. - I propose a patch for DefaultMaven, the Maven interface, and the MavenCli, which makes the DefaultMaven use the above object (get/setMavenRequestConfiguration(), and getters/ setters for the per embedder properties). - You accept the patch. - I propose a patch for the MavenEmbedder, which makes it use the DefaultMaven internally. - You accept the patch. - I propose a patch for the MavenCli, which makes it use the MavenEmbedder. Changes to the above proposal are fine for me. My intention is to get this thing going. (Remember, this is a five months old blocker!) > MavenEmbedder.execute() doesn't run reactor modules > --------------------------------------------------- > > Key: MNG-1181 > URL: http://jira.codehaus.org/browse/MNG-1181 > Project: Maven 2 > Type: Bug > Components: Embedding > Reporter: Eugene Kuleshov > Priority: Blocker > Fix For: 2.0.4 > Attachments: MNG-1181.tar.gz, MavenEmbedder2.java, MavenEmbedder2.java > > > MavenEmbedder.execute() doesn't run reactor modules. > I've been trying to run it with "generate-sources" goal, but it only build > the root project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
