Eclipse Platform uses Github for a while now and we have completely
switched to using forks for devs and contributors including protecting
the main branch from direct pushes as described here[1].
A slight (and convenient) deviation is that you do not clone your fork,
but the original repository.
The do the following:
git remote add fork <your fork url>
git remote set-url --push origin no_push
this has the advantage that whenever you pull the main branch you get it
from the target repository, so there is no immediate need to sync your
main branch in the fork. Second it prevents you from accidentally push
to the main repo.
Regarding the permission thing, the usual way to work with that is to
run the PR with minimal permissions, upload the required data (e.g. test
results) and then have a ob that is triggered by the PR completion and
runs with higher elevated permissions.
[1]
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks
Am 04.01.25 um 18:17 schrieb Konrad Windszus:
Hi,
There used to be some problems related to CI. At least ASF Jenkins
differentiates between forked PRs and non-forked PRs.
For GitHub Actions there is a difference with regards to permissions
(https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token#changing-the-permissions-in-a-forked-repository)
which might affect PR decoration and other stuff.
Are you sure that everything related to building PRs works just as well in
forks?
Konrad
On 4. Jan 2025, at 15:14, Tamás Cservenák <ta...@cservenak.net> wrote:
Howdy,
I'd like to ask devs to NOT code directly against branches in ASF
repositories, as we are swamped literally with unwanted spam: I am not
interested in each commit of the branch being worked on.
Instead, fork the repo and create PRs.
The commits ML is nearly unusable, I'd really like to see _only the
changes_ in "proper" codebases, but instead we have thousands of mails
about commits on any branch in there:
https://lists.apache.org/list.html?comm...@maven.apache.org
This also raises the problem of branch cleanup in canonical reposes as well...
TL;DR: fork and create PRs from forks please.
Thanks,
T
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
