+1 (NB) Successfully tested on a 66 module internal app suite.
On Mon, Dec 16, 2024 at 3:47 AM Delany <delany.middle...@gmail.com> wrote: > I opened https://issues.apache.org/jira/browse/MNG-8434 but its just a > collision with a property I had already set - so fixed it by renaming my > property. > The ticket can be closed. > > Another issue was with xml-maven-plugin where formerly if the base > directory of a transformationSet didn't exist the plugin would just ignore > it. With rc-2 it fails. > > The fix is easy enough: > > <configuration> > <transformationSets> > <transformationSet> > - <dir>src/main/resources/descriptors</dir> > + <dir>.</dir> > <includes> > - <include>*.descriptor</include> > + > <include>src/main/resources/descriptors/*.descriptor</include> > </includes> > > Changing my vote to +1 > Delany > > > > On Mon, 16 Dec 2024 at 09:28, Guillaume Nodet <gno...@apache.org> wrote: > > > Could you raise an issue, provide the full stack trace, and eventually a > > way to reproduce the problem please ? > > > > Le lun. 16 déc. 2024 à 08:15, Delany <delany.middle...@gmail.com> a > écrit > > : > > > > > -1 > > > I have a new issue since rc-1. > > > I get an error "recursive variable reference: build.finalName" for all > > 535 > > > modules of my project. > > > In 2 modules I set > > > "<finalName>${project.artifactId}-${project.version}</finalName>" and > in > > > another 2 modules I set "<finalName>${build.finalName}</finalName>" > where > > > build.finalName is set in a parent (that is in its own repo) as > > > "<finalName>${project.artifactId}-${project.version}</finalName>" > > > Thing is when I comment out all 4 of these uses, i.e. so that there is > no > > > finalName ever set in the project - I still get the same error. And > more > > > than removing the reference I can't think how to avoid it. > > > Google takes me to > > > > > > > > > https://maven.apache.org/ref/4-LATEST/maven-impl/apidocs/org/apache/maven/internal/impl/model/DefaultInterpolator.html > > > Delany > > > > > > > > > On Sat, 14 Dec 2024 at 02:01, Guillaume Nodet <gno...@apache.org> > wrote: > > > > > > > We solved 38 issues since rc-1. > > > > https://issues.apache.org/jira/projects/MNG/versions/12355288 > > > > > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/maven-2256/ > > > > > > > > Source release checksums: > > > > apache-maven-4.0.0-rc-2-src.tar.gz.sha512 > > > > > > > > > > > > > > > > > > d496a3650811becfe6f0047154205cf5966038791cdf7c84e83059492c92588c2e73d58a19d2463dc72571636db798fac2df9b15587e18dcf26e0c832081f654 > > > > > > > > apache-maven-4.0.0-rc-2-src.zip.sha512 > > > > > > > > > > > > > > > > > > 4a9e98267cce699d683460d65ff2b7c0fc1e5035f40d39ddbd31ca2d81bdbe7622a94d94b6a9662c3a11681263181bbef52b01c94b1946937d317fd7ae00a8fa > > > > > > > > Staged site: > > > > https://maven.apache.org/ref/4-LATEST/ > > > > > > > > Draft for release notes: > > > > https://github.com/apache/maven-site/pull/592 > > > > > > > > Guide to testing staged releases: > > > > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > Vote open for 72h > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > -- > > > > ------------------------ > > > > Guillaume Nodet > > > > > > > > > > > > > -- > > ------------------------ > > Guillaume Nodet > > >
