Re: [VOTE] Release Maven Plugin Tools version 3.10.1

[Michael Osipov]

If necessary, spawn a new issue to further discuss this. I will continue 
with the release meanwhile...

Am 2023-10-20 um 17:51 schrieb Konrad Windszus:
Hi everyone,
Sorry for the late response.
Those changes were done deliberate due to what Michael said before.
Should have mentioned that before.
Does this require a dedicated JIRA with description or is it fine to improve 
the semantics like this silently (I fail to see any functional impact here 
apart from the colouring)?
Konrad

On 19. Oct 2023, at 09:20, Michael Osipov <micha...@apache.org> wrote:

Went through the two cases, I believe that they are fine (or more logical than 
before):

1. Change in link style:
before:
<code>
<a href="#fast">&lt;fast&gt;</a>
</code>

after:
<a href="#fast">
  <code>&lt;fast&gt;</code>
</a>

Definition of <code> says [1]: A few other elements belong to this category, 
but only if a specific condition is fulfilled:

    <a>, if it contains only phrasing content

I don't know wether this applies. I'd rather format the link than the code with 
link, like done now.

2. No link highlight of target anchors:before:
<section>
  <h4>
    <a name="a.3CexcludeDefaultDirectories.3E"></a>
    <b>
      <a name="excludeDefaultDirectories">&lt;excludeDefaultDirectories&gt;</a>
    </b>
  </h4>
...

after:
<a name="Parameter_Details"></a>
<a name="excludeDefaultDirectories">
  <section>
    <h4>
      <a 
name="a.3CexcludeDefaultDirectories.3E"></a>&lt;excludeDefaultDirectories&gt;
    </h4>
    <a name="a.3CexcludeDefaultDirectories.3E"></a>
  </a>
...

Previously, the anchor (where we jump to) was highlighted although it does not 
jump anywhere. I'd expect to highlight if you want to jump somewhere and not 
from.

Note that with the Doxia 2.0.0 stack it will further simplify and we will 
review this again.

Konrad, maybe you want to add some words?

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/code

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org