Again: cause the PR which is not merged is already not sufficient for the LTS of september. Asm version is a running forward game and technically we don't need it _there_ so if we can make it effortless I think it could only have a positive impact on the project. Concretely the 9.4 (the PR) does not support the next LTS (21), see https://gitlab.ow2.org/asm/asm/-/blob/master/asm/src/main/java/org/objectweb/asm/Opcodes.java#L289 and compare to 9.4 release/branch for ex.
Le mar. 24 janv. 2023 à 19:01, Tamás Cservenák <[email protected]> a écrit : > Howdy, > > Why again? > > There is ongoing effort (master is already updated), but also to raise > whole Java level of Sisu, see > https://github.com/eclipse/sisu.inject/pull/72 > Hopefully soon new sisu release will happen that will contain updated ASM > and allow using Java11+ bytecode. > > Thanks > T > > > On Tue, Jan 24, 2023 at 6:58 PM Romain Manni-Bucau <[email protected]> > wrote: > > > Hi all, > > > > We are hit again by sisu asm, we cant write a component using sisu Named > > SPI if compiled with java 17 (since then it will be visited with a too > old > > asm - exception at the end), do we want to upgrade asm there, do we want > to > > plan drop it - guess we can using the annot processor to collect more > data? > > > > > > Exception: > > > > java.lang.IllegalArgumentException > > at org.eclipse.sisu.space.asm.ClassReader.<init>(ClassReader.java:170) > > at org.eclipse.sisu.space.asm.ClassReader.<init>(ClassReader.java:153) > > at org.eclipse.sisu.space.asm.ClassReader.<init>(ClassReader.java:424) > > at org.eclipse.sisu.space.SpaceScanner.accept(SpaceScanner.java:102) > > at org.eclipse.sisu.space.SpaceScanner.accept(SpaceScanner.java:78) > > at org.eclipse.sisu.space > > .SpaceModule.scanForElements(SpaceModule.java:168) > > at org.eclipse.sisu.space.SpaceModule.configure(SpaceModule.java:129) > > at > > > > > org.eclipse.sisu.plexus.PlexusAnnotatedBeanModule.configure(PlexusAnnotatedBeanModule.java:102) > > at > > > > > org.eclipse.sisu.plexus.PlexusBindingModule.configure(PlexusBindingModule.java:63) > > at > > com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:409) > > at com.google.inject.spi.Elements.getElements(Elements.java:108) > > at com.google.inject.spi.Elements.getElements(Elements.java:101) > > at org.eclipse.sisu.wire.WireModule.configure(WireModule.java:75) > > at > > com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:409) > > at com.google.inject.spi.Elements.getElements(Elements.java:108) > > at > > > > > com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:160) > > at > > > > > com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107) > > at com.google.inject.Guice.createInjector(Guice.java:87) > > at com.google.inject.Guice.createInjector(Guice.java:69) > > at com.google.inject.Guice.createInjector(Guice.java:59) > > at > > > > > org.codehaus.plexus.DefaultPlexusContainer.addPlexusInjector(DefaultPlexusContainer.java:481) > > at > > > > > org.codehaus.plexus.DefaultPlexusContainer.<init>(DefaultPlexusContainer.java:206) > > at org.apache.maven.cli.MavenCli.container(MavenCli.java:585) > > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:274) > > at org.apache.maven.cli.MavenCli.main(MavenCli.java:197) > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github < > > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > < > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > >
