On 29/11/2022 22:22, Elliotte Rusty Harold wrote:
https://github.com/apache/maven/pull/845 is IMHO ready to merge into
core. This is from an external contributor. Can someone point me to or
remind me of the steps for getting this PR to run in Jenkins? It has
passed our Github CI checks.
I don't know of any formal procedure. Shortly after I became a
committer, I noticed the same thing: there is no document that describes
how to do this. I then proposed a process [1] but I did not feel it
reached a consensus, so I left it as is. Even the branch in Git has gone
by now.
To answer your question, what I typically do is:
* download a patch of the pull request (add .patch to the URL of the PR)
* create a branch from master on my machine
* apply the patch file to that fresh branch
* squash all the commits into one
* push that branch with one commit to ASF GitBox
* wait for Jenkins
If that succeeds, I can push the squashed commit to master. Usually I
add a second line to the commit message saying "Closes #845" so the
GitHub pull request is closed automatically.
HTH,
Maarten
[1] https://lists.apache.org/thread/68mg4mj9ppdpdhgbd49nshrhr3xfloyq
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
