I tried to come up with an implementation in https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/81, but there is a subtle difference to using plexus metadata. Now plugins versions inside the mapping are required, with plexus metadata they weren't. Does anyone know where the difference comes from?
Thanks, Konrad On 2022/07/14 07:10:08 Konrad Windszus wrote: > Hi Tamás, > thanks a lot for that example. Unfortunately one cannot use > `o.a.m.lifecycle.mapping.Lifecycle.setPhases(Map<String,String>)` due to > https://issues.apache.org/jira/browse/MNG-5958 in Maven [3.3.9,3.5.0). > So an implementation of LifecycleMapping or Provider<LifecycleMapping> is > unfortunately requiring a lot of glue code currently... > > Konrad > > > On 2022/07/12 14:23:26 Tamás Cservenák wrote: > > Howdy, > > > > just for fun I hit the same issue, and this is how I got rid of Plexus XML > > https://github.com/apache/maven-rar-plugin/pull/3/files#diff-b7fae2df008a8b4ad8bc93e5c2229a5768fbdc77e904615d706c5c29e5ad4997 > > > > HTH > > T > > > > On Wed, Jul 6, 2022 at 4:26 PM Konrad Windszus <k...@apache.org> wrote: > > > > > > > > > > > On 2022/07/06 14:18:28 Tamás Cservenák wrote: > > > > Maven 3.0 did not support sisu-index (produced by sisu-maven-plugin > > > during > > > > build), but 3.1 onward does support it. > > > > > > > > Hence. If you support Maven 3.0 inclusive, you must stick with plexus > > > xml, > > > > otherwise is not required. > > > > > > > > T > > > > > > The problem is not the support of sisu-index but rather the missing > > > constructor or public fields of > > > https://github.com/apache/maven/blob/maven-3.8.6/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java > > > and I don't want to implement > > > https://github.com/apache/maven/blob/90c084dcf495e73c679395bc4b050500cbccf8cf/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/LifecycleMapping.java#L28 > > > from scratch. > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
