Howdy, In your example rule, between 1st and 2nd step I'd insert some "invite interested parties" step, that is either request review using GH UI, or ping party via mail... As currently our incoming email amount is huge, it is way too easy to miss some. Also, when asked for review, the one asked by going to https://github.com/pulls can easily glean over where the review is needed.
T On Tue, Jan 25, 2022 at 8:47 PM Slawomir Jaranowski <s.jaranow...@gmail.com> wrote: > Hi, > > On the page "Apache Maven Project Roles" [1] we have paragraph > about Committers with: > > The Apache Maven project uses a Commit then Review policy and has a number > of conventions which should be followed. > > > Looks like Review then Commit policy is from svn time, so should be > refreshed or confirmed that is actual. > > When we want Review than Commit policy, we need some rules which allow us > to effectively work if nobody is interested for feedback. > We also need rules / examples for direct commits, when they are acceptable. > > Do we need different rules for Maven core, plugins, shared ... etc > > Example of rule: > > PR -> no feedback for X days -> send a mail on dev@, if still not feedback > after X days after mail -> proceed alone > > [1] https://maven.apache.org/project-roles.html#committers > > -- > Sławomir Jaranowski >
