Good part is, even though I followed the docs I couldn't get it to work for even one repo (maven-site). It still has the "Squash & merge" button.
The guide I was proposing was for working with pull requests submitted by contributors, not for creating them. So I wasn't planning to add any words on when to create a pull request or not. I do agree that there's a lot of email generated. Sometimes even multiple emails with the same content in them. I think we should solve that by sending less notifications, not by creating less pull requests. There must be a way, somewhere, to disable either the Github ones or the Gitbox ones. Maarten On 14/07/2020 08:25, Olivier Lamy wrote: > Well personally I'm happy to use it for myself... > so please don;t remove it. > One of the most important point of the guide could be > ***DO NOT CREATE PULL REQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED > REVIEW*** > > it's very noisy and useless notifications (especially because we get > from both gitbox and github....) > > > On Tue, 14 Jul 2020 at 16:18, Maarten Mulders <mthmuld...@apache.org> > wrote: > >> Good point. I'll start by disabling the "Squash & merge" button using >> asf.yaml for the repositories I have cloned locally. >> >> Maarten >> >> On 13/07/2020 22:03, Elliotte Rusty Harold wrote: >>>>> So then the conclusion is, we can use Github for accepting & merging >>>>> pull requests, but shouldn't use "Squash & merge"? >>> >>> Buttons that shouldn't be used can be turned off by project owners in >>> the repo settings. There's no need to bother devs with remembering >>> which buttons should and should not be pressed (especially since >>> you'll get different answers to this question depending on who you >>> ask.) >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
