Hi Michael,
> I have made several comments. Please review and update otherwise I cannot
> proceed on the merge.
I take a look.
Thats a lot of auto formatting things.
It’s quite difficult to manage these over different projects in Netbeans.
I'll fix that.
> Additionally, I am waiting for an answer to my question:
> The PR looks good as it does not change the default behavior. Though, I do
> not understand how it is supposed to solve the problem because your default
> impl of VersionRangeResultFilter does nothing. Are you going to add your
> custom implementation to {maven.home}/lib/ext?
That's Right.
Over the years there were more than one and opposing views how is the right
solution for resolving version range.
This PR give the possibility to use a strategy you like.
The default implementation must not be changed to give this PR a change to
merge (see comments at the PR).
The custom implementation could be placed in {maven.home}/lib/ext or maybe also
as extension in .mvn/ per project.
> Even if I would merge, the issue wouldn't be resolved. Is that correct?
More or less.
Now it provides an API to add a filter you like.
It could be the solution for this issue while we would not change the default
behaviour or provide different strategies in Maven core.
Adding a documentation and an example on this issue and everyone might
implement a solution he likes/needs.
-- barthel
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
