I tried on Windows: it does not work yet Th eissue I'm facing is: we need to call AnsiConsole.systemInstall() for Windows But if this call is added in MavenCli.doMain(), core ITs fail since there is confusion on System.out replacements...
I still didn't find any way to avoid this confusion: if somebody has an idea... Regards, Hervé Le lundi 6 juin 2016 16:15:48 Petar Tahchiev a écrit : > Sorry, I got confused by this: "if run with older Maven, color is always > on". > > I will try it later. > > 2016-06-06 15:46 GMT+02:00 Tamás Cservenák <[email protected]>: > > I believe you need to build Maven itself from Herve's branch: > > https://github.com/apache/maven/tree/MNG-3507 > > > > On Mon, Jun 6, 2016 at 3:14 PM Petar Tahchiev <[email protected]> > > > > wrote: > > > I might be doing smth wrong but I tested on windows 10 with Maven 3.3.9 > > > > and > > > > > I didn't see any color. Here's what I did: > > > > > > 1) git clone [email protected]:apache/maven-shared.git > > > 2) cd maven-share/ && mvn clean install > > > 3) git clone [email protected]:apache/maven-integration-testing.git > > > 4) cd maven-integration-testing && mvn clean install > > > > > > I also tried to build only that particular module too: > > > 5) cd maven-integration-testing\core-it-support\maven-it-helper\ && mvn > > > clean install > > > > > > The result is > > > > > > ------------------------------------------------------- > > > > > > T E S T S > > > > > > ------------------------------------------------------- > > > Running org.apache.maven.it.MavenIntegrationTestCaseTest > > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.425 > > > > sec - > > > > > in org.apache.maven.it.MavenIntegrationTestCaseTest > > > > > > Results : > > > > > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > > > > > [INFO] > > > [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ maven-it-helper --- > > > > > [INFO] Building jar: > > C:\workspace\maven-integration-testing\core-it-support\maven-it-helper\tar > > get\maven-it-helper-2.1-SNAPSHOT.jar> > > > and no color. > > > > > > 2016-06-06 14:31 GMT+02:00 jieryn <[email protected]>: > > > > Also, to get Jenkins displaying ANSI escape codes for color you can > > > > install https://wiki.jenkins-ci.org/display/JENKINS/AnsiColor+Plugin > > > > and then enable it per-job. > > > > > > > > On Mon, Jun 6, 2016 at 2:33 AM, Romain Manni-Bucau > > > > > > > > <[email protected]> wrote: > > > > > Hi Hervé, > > > > > > > > > > would it be possible to enhance this with such features: > > > > > > > > > > 1. make colors configurables through a user config > > > > (~/.m2/settings.xml? > > > > > > or > > > > > > > > > colors.xml) > > > > > 2. make color config regex friendly. The idea is to be able to get a > > > > > coloration like https://github.com/rmannibucau/maven-color which > > > > > > depends > > > > > > > > what is shown and not only the level > > > > > > > > > > ? > > > > > > > > > > Anyway thanks for moving forward this feature expected for too long > > > > by > > > > > a > > > > > > > > LOT of users! > > > > > > > > > > Romain Manni-Bucau > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > > > <http://rmannibucau.wordpress.com> | Github < > > > > > > > > https://github.com/rmannibucau> | > > > > > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > > > > > <http://www.tomitribe.com> | JavaEE Factory > > > > > <https://javaeefactory-rmannibucau.rhcloud.com> > > > > > > > > > > 2016-06-06 8:26 GMT+02:00 Hervé BOUTEMY <[email protected]>: > > > > >> Hi, > > > > >> > > > > >> As you may have noticed, I created a MNG-3507 branch. > > > > >> The idea here is to develop colorization not at slf4j > > > > >> implementation > > > > > > > > level, > > > > > > > > >> but in core (and later plugins): slf4j implementation is only > > > > > > > > responsible > > > > > > > > >> for > > > > >> DEBUG/INFO/WARNING/ERROR colorization, core and plugins are > > > > > > responsible > > > > > > > for > > > > > > > > >> messages. > > > > >> > > > > >> I implemented message colorization that J Dillon did in > > > > slf4j-gossip: > > > > the > > > > > > > > >> only > > > > >> part I still didn't do is the stacktrace enhancement. > > > > >> Batch mode disables color: we can choose to create specific CLI > > > > > > options > > > > > > > >> later > > > > >> if we prefer. > > > > >> And the most important is that core provides jansi to plugins: any > > > > > > > > plugin > > > > > > > > >> using jansi benefits from jansi configuration (mainly > > > > >> enable/disable > > > > > > > > color) > > > > > > > > >> As a proof of concept, I implemented color output in core ITs > > > > invoker > > > > > > [1]: > > > > >> if > > > > >> run with older Maven, color is always on (since core doesn't > > > > >> provide > > > > >> configured jansi), but if run with the branch, the plugin has color > > > > >> deactivated in batch mode. > > > > >> As you can see, also, Jenkins doesn't display ansi code nicely > > > > [2]... > > > > > > >> I also updated some IT test code to strip ansi codes [3] and not > > > > choke > > > > > > with > > > > > > > > >> color on. > > > > >> > > > > >> I still need to test on Windows, if nobody beats me at it. > > > > >> > > > > >> If nobody objects, I'll merge code to master and update > > > > >> slf4j-gossip > > > > >> accordingly (a lot of features are now in core): the discussion on > > > > > > > > changing > > > > > > > > >> default slf4j implementation will happen a little bit later. > > > > >> > > > > >> Regards, > > > > >> > > > > >> Hervé > > > > >> > > > > >> > > > > >> [1] > > > > http://git-wip-us.apache.org/repos/asf/maven-integration-testing/commit/13 > > bd5416> > > > > >> [2] > > > > https://builds.apache.org/view/M-R/view/Maven/job/core-integration-testing > > -maven-3-embedded/7280/console> > > > > >> [3] http://svn.apache.org/r1746888 > > > > --------------------------------------------------------------------- > > > > > > >> To unsubscribe, e-mail: [email protected] > > > > >> For additional commands, e-mail: [email protected] > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > -- > > > Regards, Petar! > > > Karlovo, Bulgaria. > > > --- > > > Public PGP Key at: > > > http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x19658550C3110611 > > > Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
