[ 
https://issues.apache.org/jira/browse/SOLR-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844692#comment-13844692
 ] 

Joel Bernstein edited comment on SOLR-5416 at 12/10/13 10:08 PM:
-----------------------------------------------------------------

I uploaded a patch created from trunk which I believe resolves the issues. I 
started out attempting to fix this in a more generic way but ended up needing 
to get very specific to not break other test cases. 

The issue with the other test cases is that the patch I added won't work if the 
main query is excluded. But for the CollapsingQParserPlugin, then main query is 
always needed anyway to support collapsing by score. So to not break a test 
case which excluded the main query, I routed only requests that use the 
CollapsingQParserPlugin to the new method that scores while creating the docset.

The next step is to throw an exception if someone tries to exclude the main 
query while using the CollapsingQParserPlugin. 

David, when you get a chance could you test this patch out and see if it 
resolves the issue for you. If the patch doesn't apply for you I'll create one 
for your version of Solr.

Joel


was (Author: joel.bernstein):
I uploaded a patch created from trunk which I believe resolves the issues. I 
started out attempting to fix this in a more generic way but ended up needing 
to get very specific to not break other test cases. 

The issue with the other test cases is that the patch I added won't work if the 
main query is excluded. But for the CollapsingQParserPlugin, then main query is 
always needed anyway to support collapsing by score. So to not break a test 
case which excluded the main query, I routed only requests that use the 
CollapsingQParserPlugin to the new method that scores while creating the docset.

The next step is to throw an exception if some tries to exclude the main query 
while using the CollapsingQParserPlugin. 

David, when you get a chance could you test this patch out and see if it 
resolves the issue for you. If the patch doesn't apply for you I'll create one 
for your version of Solr.

Joel

> CollapsingQParserPlugin bug with Tagging
> ----------------------------------------
>
>                 Key: SOLR-5416
>                 URL: https://issues.apache.org/jira/browse/SOLR-5416
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 4.6
>            Reporter: David
>            Assignee: Joel Bernstein
>              Labels: group, grouping
>             Fix For: 5.0, 4.7
>
>         Attachments: SOLR-5416.patch, SOLR-5416.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Trying to use CollapsingQParserPlugin with facet tagging throws an exception. 
> {code}
>  ModifiableSolrParams params = new ModifiableSolrParams();
>     params.add("q", "*:*");
>     params.add("fq", "{!collapse field=group_s}");
>     params.add("defType", "edismax");
>     params.add("bf", "field(test_ti)");
>     params.add("fq","{!tag=test_ti}test_ti:5");
>     params.add("facet","true");
>     params.add("facet.field","{!ex=test_ti}test_ti");
>     assertQ(req(params), "*[count(//doc)=1]", 
> "//doc[./int[@name='test_ti']='5']");
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to