[
https://issues.apache.org/jira/browse/LUCENE-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788571#comment-13788571
]
Uwe Schindler commented on LUCENE-5262:
---------------------------------------
Shai, it's fine to not fix this now! This supressed Exceptions success=true
antipattern is another big problem. I was just feeling bad because you did the
opposite Robert fixed for TokenStreams yesterday. But IndexWriter is still full
of this antipattern, so we should take the time to fix it :-)
> StandardDirectoryReader should decRef readers on exception, not close them
> --------------------------------------------------------------------------
>
> Key: LUCENE-5262
> URL: https://issues.apache.org/jira/browse/LUCENE-5262
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5262.patch
>
>
> I've hit this while debugging a test, and was able to reproduce with a simple
> testcase. StandardDirectoryReader.open (nrt) calls IOUtils.close() on hitting
> an exception from RLD.getReadOnlyClone. But this is wrong, since if two
> attempts are made to obtain an NRT reader, and both of them fail, the readers
> that were closed on the first time are no longer closed, since their "closed"
> member is true. It should instead decRef() them. I'll upload a testcase and
> fix shortly.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
