[
https://issues.apache.org/jira/browse/SOLR-5302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787219#comment-13787219
]
Erick Erickson commented on SOLR-5302:
--------------------------------------
I've assigned this to myself to commit & etc. I'll need all the help anyone
wants to lend as far as the technical details are concerned, this is a lot of
code in places I'm not all that familiar with, and like everyone else I have
faaaar too many things on my plate :)
Steven & co:
A couple of procedural details:
1> There's no need at all to remove old patches when you put new ones up, in
fact it's preferable to leave the old ones there. Just name them _all_
SOLR-5302.patch. The newest version will be in blue and all the older versions
will be gray and they're listed in date order so it's really easy to know the
order and look at changes version-to-version should that be necessary.
2> At some point when we're in some agreement (very soon I hope!), I'll commit
the patch to trunk where we can bang on it a while before merging into 4x. I'll
try to turn any new patches around in a day or less when we get to that point.
I'm weaseling here since I'll be traveling for 10 days or so starting this
weekend, otherwise I should be faster....
I applied the patch to trunk and there are two issues:
3a> A couple of files have this: "import org.apache.mahout.math.Arrays;", and
as far as I can tell it only is for the toString operation in error messages.
The code compiles if we just use the java.util.Arrays import. I'd rather not
introduce a new dependency so how about switching to java.util.Arrays?
3b> Trying to run the tests on trunk at least gives this error: "dynamicField
can not have a default value: *_i. " (there are a couple of others). See
SOLR-5227 which CHANGES.txt claims that setting the default and required
options was silently ignored anyway as of 4.5 and emits a new init error...
Removing the default assignments gets us past the initialization error, but
then several tests fail, stack trace at the end (TRUNK), I haven't pursued it
yet:
Thanks loads for taking this all no and contributing it back! I'll do my best
to get it into the code base as fast as possible. And the patch comes with
documentation too! How cool is that!
Erick
java.lang.NullPointerException
at __randomizedtesting.SeedInfo.seed([22E0CD041D7B8CF3]:0)
at
org.apache.solr.analytics.util.valuesource.MissFieldSource.description(MissFieldSource.java:52)
at
org.apache.lucene.queries.function.ValueSource.toString(ValueSource.java:58)
at
org.apache.solr.analytics.statistics.StatsCollectorSupplierFactory.create(StatsCollectorSupplierFactory.java:159)
at
org.apache.solr.analytics.accumulator.BasicAccumulator.<init>(BasicAccumulator.java:60)
at
org.apache.solr.analytics.accumulator.BasicAccumulator.create(BasicAccumulator.java:84)
at
org.apache.solr.analytics.request.AnalyticsStats.execute(AnalyticsStats.java:82)
at
org.apache.solr.handler.component.AnalyticsComponent.process(AnalyticsComponent.java:44)
at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:209)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:1861)
at org.apache.solr.util.TestHarness.query(TestHarness.java:291)
at org.apache.solr.util.TestHarness.query(TestHarness.java:273)
at
org.apache.solr.analytics.NoFacetTest.beforeClass(NoFacetTest.java:103)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1559)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.access$600(RandomizedRunner.java:79)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:677)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:693)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:53)
at
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46)
at
org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42)
at
com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55)
at
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
at
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:43)
at
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48)
at
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70)
at
org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:55)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358)
at java.lang.Thread.run(Thread.java:722)
> Analytics Component
> -------------------
>
> Key: SOLR-5302
> URL: https://issues.apache.org/jira/browse/SOLR-5302
> Project: Solr
> Issue Type: New Feature
> Reporter: Steven Bower
> Assignee: Erick Erickson
> Attachments: Search Analytics Component.pdf,
> solr_analytics-2013.10.04-2.patch, Statistical Expressions.pdf
>
>
> This ticket is to track a "replacement" for the StatsComponent. The
> AnalyticsComponent supports the following features:
> * All functionality of StatsComponent (SOLR-4499)
> * Field Faceting (SOLR-3435)
> ** Support for limit
> ** Sorting (bucket name or any stat in the bucket
> ** Support for offset
> * Range Faceting
> ** Supports all options of standard range faceting
> * Query Faceting (SOLR-2925)
> * Ability to use overall/field facet statistics as input to range/query
> faceting (ie calc min/max date and then facet over that range
> * Support for more complex aggregate/mapping operations (SOLR-1622)
> ** Aggregations: min, max, sum, sum-of-square, count, missing, stddev, mean,
> median, percentiles
> ** Operations: negation, abs, add, multiply, divide, power, log, date math,
> string reversal, string concat
> ** Easily pluggable framework to add additional operations
> * New / cleaner output format
> Outstanding Issues:
> * Multi-value field support for stats (supported for faceting)
> * Multi-shard support (may not be possible for some operations, eg median)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
