[
https://issues.apache.org/jira/browse/SOLR-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774412#comment-13774412
]
Elran Dvir commented on SOLR-5084:
----------------------------------
Hi Erick,
Thanks for the feedback.
1) I think your suggestion would be much better, especially if we can keep the
syntax fairly compact. However I would like to separate that effort from this
change (it might apply to CurrencyField and other use cases so might warrant a
different issue)
1.5) gone in today's patch.
2)I'm not seeing 17 in the patch, I have ENUM_FIELD_VALUE as 18. I rechecked
for the today's patch as well - not sure where the difference is coming from
3)I am not checking null value of this.max. I am checking null value of the
parameter max of the function. So this.max should be set to non-null.
4) usage of isNullOrEmpty - again, I've removed the isNullOrEmpty code in the
Sep 1st patch. Can't explain why you are still seeing it... I also have an
override of storedToIndexed showing in my patch
5) there were inclusive range tests in the function testEnumRangeSearch. I have
added now exclusive range tests in today's patch .
I have removed leading underscores from members in today's patch.
Thanks!
> new field type - EnumField
> --------------------------
>
> Key: SOLR-5084
> URL: https://issues.apache.org/jira/browse/SOLR-5084
> Project: Solr
> Issue Type: New Feature
> Reporter: Elran Dvir
> Assignee: Erick Erickson
> Attachments: enumsConfig.xml, schema_example.xml, Solr-5084.patch,
> Solr-5084.patch, Solr-5084.patch, Solr-5084.patch, Solr-5084.trunk.patch,
> Solr-5084.trunk.patch, Solr-5084.trunk.patch
>
>
> We have encountered a use case in our system where we have a few fields
> (Severity. Risk etc) with a closed set of values, where the sort order for
> these values is pre-determined but not lexicographic (Critical is higher than
> High). Generically this is very close to how enums work.
> To implement, I have prototyped a new type of field: EnumField where the
> inputs are a closed predefined set of strings in a special configuration
> file (similar to currency.xml).
> The code is based on 4.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
